Skip to content

Commit

Permalink
x86: introduce frame_pointer() and stack_pointer()
Browse files Browse the repository at this point in the history
This patch defines frame_pointer() and stack_pointer() similar to the
already defined instruction_pointer(). Thus the oprofile code can be
written in a more readable fashion.

[ tglx: arch/x86 adaptation ]

Signed-off-by: Jan Blunck <jblunck@suse.de>
Signed-off-by: Andi Kleen <ak@suse.de>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
  • Loading branch information
Jan Blunck authored and Thomas Gleixner committed Oct 19, 2007
1 parent ab48357 commit f1df280
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 10 deletions.
12 changes: 2 additions & 10 deletions arch/x86/oprofile/backtrace.c
Original file line number Diff line number Diff line change
Expand Up @@ -76,16 +76,8 @@ dump_user_backtrace(struct frame_head * head)
void
x86_backtrace(struct pt_regs * const regs, unsigned int depth)
{
struct frame_head *head;
unsigned long stack;

#ifdef CONFIG_X86_64
head = (struct frame_head *)regs->rbp;
stack = regs->rsp;
#else
head = (struct frame_head *)regs->ebp;
stack = regs->esp;
#endif
struct frame_head *head = (struct frame_head *)frame_pointer(regs);
unsigned long stack = stack_pointer(regs);

if (!user_mode_vm(regs)) {
if (depth)
Expand Down
2 changes: 2 additions & 0 deletions include/asm-x86/ptrace_32.h
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,8 @@ static inline int v8086_mode(struct pt_regs *regs)
}

#define instruction_pointer(regs) ((regs)->eip)
#define frame_pointer(regs) ((regs)->ebp)
#define stack_pointer(regs) ((regs)->esp)
#define regs_return_value(regs) ((regs)->eax)

extern unsigned long profile_pc(struct pt_regs *regs);
Expand Down
2 changes: 2 additions & 0 deletions include/asm-x86/ptrace_64.h
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@ struct pt_regs {
#define user_mode(regs) (!!((regs)->cs & 3))
#define user_mode_vm(regs) user_mode(regs)
#define instruction_pointer(regs) ((regs)->rip)
#define frame_pointer(regs) ((regs)->rbp)
#define stack_pointer(regs) ((regs)->rsp)
#define regs_return_value(regs) ((regs)->rax)

extern unsigned long profile_pc(struct pt_regs *regs);
Expand Down

0 comments on commit f1df280

Please sign in to comment.