Skip to content

Commit

Permalink
netxen: No need to check vfree() pointer.
Browse files Browse the repository at this point in the history
vfree() does its own 'NULL' check, so no need for check before
calling it.

Signed-off-by: Figo.zhang <figo1802@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Figo.zhang authored and David S. Miller committed Jun 11, 2009
1 parent 934037b commit f2333a0
Showing 1 changed file with 3 additions and 6 deletions.
9 changes: 3 additions & 6 deletions drivers/net/netxen/netxen_nic_init.c
Original file line number Diff line number Diff line change
Expand Up @@ -178,10 +178,8 @@ void netxen_free_sw_resources(struct netxen_adapter *adapter)

for (ring = 0; ring < adapter->max_rds_rings; ring++) {
rds_ring = &recv_ctx->rds_rings[ring];
if (rds_ring->rx_buf_arr) {
vfree(rds_ring->rx_buf_arr);
rds_ring->rx_buf_arr = NULL;
}
vfree(rds_ring->rx_buf_arr);
rds_ring->rx_buf_arr = NULL;
}
kfree(recv_ctx->rds_rings);

Expand All @@ -190,8 +188,7 @@ void netxen_free_sw_resources(struct netxen_adapter *adapter)
return;

tx_ring = adapter->tx_ring;
if (tx_ring->cmd_buf_arr)
vfree(tx_ring->cmd_buf_arr);
vfree(tx_ring->cmd_buf_arr);
}

int netxen_alloc_sw_resources(struct netxen_adapter *adapter)
Expand Down

0 comments on commit f2333a0

Please sign in to comment.