Skip to content

Commit

Permalink
RDS: don't pretend to use cpu notifiers
Browse files Browse the repository at this point in the history
It looks like an attempt to use CPU notifier here which was never
completed. Nobody tried to wire it up completely since 2k9. So I unwind
this code and get rid of everything not required. Oh look! 19 lines were
removed while code still does the same thing.

Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>
Tested-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Sebastian Andrzej Siewior authored and David S. Miller committed Dec 22, 2015
1 parent 5c29482 commit f2830d0
Showing 1 changed file with 6 additions and 25 deletions.
31 changes: 6 additions & 25 deletions net/rds/page.c
Original file line number Diff line number Diff line change
Expand Up @@ -179,37 +179,18 @@ int rds_page_remainder_alloc(struct scatterlist *scat, unsigned long bytes,
}
EXPORT_SYMBOL_GPL(rds_page_remainder_alloc);

static int rds_page_remainder_cpu_notify(struct notifier_block *self,
unsigned long action, void *hcpu)
void rds_page_exit(void)
{
struct rds_page_remainder *rem;
long cpu = (long)hcpu;
unsigned int cpu;

rem = &per_cpu(rds_page_remainders, cpu);
for_each_possible_cpu(cpu) {
struct rds_page_remainder *rem;

rdsdebug("cpu %ld action 0x%lx\n", cpu, action);
rem = &per_cpu(rds_page_remainders, cpu);
rdsdebug("cpu %u\n", cpu);

switch (action) {
case CPU_DEAD:
if (rem->r_page)
__free_page(rem->r_page);
rem->r_page = NULL;
break;
}

return 0;
}

static struct notifier_block rds_page_remainder_nb = {
.notifier_call = rds_page_remainder_cpu_notify,
};

void rds_page_exit(void)
{
int i;

for_each_possible_cpu(i)
rds_page_remainder_cpu_notify(&rds_page_remainder_nb,
(unsigned long)CPU_DEAD,
(void *)(long)i);
}

0 comments on commit f2830d0

Please sign in to comment.