Skip to content

Commit

Permalink
fastboot: Make libata initialization even more async
Browse files Browse the repository at this point in the history
As suggested by Linus: Don't do the libata init in 2 separate
steps with a global sync inbetween, but do it as one async step,
with a local sync before registering the device.

This cuts the boottime on my machine with 2 sata controllers down
significantly, and it seems to work. Would be nice if the libata
folks take a good look at this patch though..

Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>
  • Loading branch information
Arjan van de Ven committed Jan 7, 2009
1 parent 7931805 commit f29d3b2
Showing 1 changed file with 7 additions and 9 deletions.
16 changes: 7 additions & 9 deletions drivers/ata/libata-core.c
Original file line number Diff line number Diff line change
Expand Up @@ -5951,6 +5951,12 @@ static void async_port_probe(void *data, async_cookie_t cookie)
*/
}
}

/* in order to keep device order, we need to synchronize at this point */
async_synchronize_cookie(cookie);

ata_scsi_scan_host(ap, 1);

}
/**
* ata_host_register - register initialized ATA host
Expand Down Expand Up @@ -6033,15 +6039,7 @@ int ata_host_register(struct ata_host *host, struct scsi_host_template *sht)
struct ata_port *ap = host->ports[i];
async_schedule(async_port_probe, ap);
}
async_synchronize_full();
/* probes are done, now scan each port's disk(s) */
DPRINTK("host probe begin\n");
for (i = 0; i < host->n_ports; i++) {
struct ata_port *ap = host->ports[i];

ata_scsi_scan_host(ap, 1);
}
DPRINTK("host probe end\n");
DPRINTK("probe end\n");

return 0;
}
Expand Down

0 comments on commit f29d3b2

Please sign in to comment.