Skip to content

Commit

Permalink
char: lack of bool string made CONFIG_DEVPORT always on
Browse files Browse the repository at this point in the history
Without a bool string present, using "# CONFIG_DEVPORT is not set" in
defconfig files would not actually unset devport. This esnured that
/dev/port was always on, but there are reasons a user may wish to
disable it (smaller kernel, attack surface reduction) if it's not being
used. Adding a message here in order to make this user visible.

Signed-off-by: Max Bires <jbires@google.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Max Bires authored and Greg Kroah-Hartman committed Jan 11, 2017
1 parent 874bcd0 commit f2cfa58
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion drivers/char/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -571,9 +571,12 @@ config TELCLOCK
controlling the behavior of this hardware.

config DEVPORT
bool
bool "/dev/port character device"
depends on ISA || PCI
default y
help
Say Y here if you want to support the /dev/port device. The /dev/port
device is similar to /dev/mem, but for I/O ports.

source "drivers/s390/char/Kconfig"

Expand Down

0 comments on commit f2cfa58

Please sign in to comment.