Skip to content

Commit

Permalink
opp: of: drop incorrect lockdep_assert_held()
Browse files Browse the repository at this point in the history
_find_opp_of_np() doesn't traverse the list of OPP tables but instead
just the entries within an OPP table and so only requires to lock the
OPP table itself.

The lockdep_assert_held() was added there by mistake and isn't really
required.

Fixes: 5d6d106 ("OPP: Populate required opp tables from "required-opps" property")
Cc: v5.0+ <stable@vger.kernel.org> # v5.0+
Reported-by: Niklas Cassel <niklas.cassel@linaro.org>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
  • Loading branch information
Viresh Kumar committed Oct 10, 2019
1 parent 54ecb8f commit f2edbb6
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions drivers/opp/of.c
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,6 @@ static struct dev_pm_opp *_find_opp_of_np(struct opp_table *opp_table,
{
struct dev_pm_opp *opp;

lockdep_assert_held(&opp_table_lock);

mutex_lock(&opp_table->lock);

list_for_each_entry(opp, &opp_table->opp_list, node) {
Expand Down

0 comments on commit f2edbb6

Please sign in to comment.