Skip to content

Commit

Permalink
x86/microcode/core: Return an error only when necessary
Browse files Browse the repository at this point in the history
Return an error from the late loading function which is run on each CPU
only when an error has actually been encountered during the update.

Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
Link: https://lore.kernel.org/r/20230130161709.11615-5-bp@alien8.de
  • Loading branch information
Borislav Petkov (AMD) committed Feb 6, 2023
1 parent 7ff6edf commit f33e0c8
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions arch/x86/kernel/cpu/microcode/core.c
Original file line number Diff line number Diff line change
Expand Up @@ -409,10 +409,10 @@ static int __reload_late(void *info)
goto wait_for_siblings;

if (err >= UCODE_NFOUND) {
if (err == UCODE_ERROR)
if (err == UCODE_ERROR) {
pr_warn("Error reloading microcode on CPU %d\n", cpu);

ret = -1;
ret = -1;
}
}

wait_for_siblings:
Expand Down

0 comments on commit f33e0c8

Please sign in to comment.