Skip to content

Commit

Permalink
reset: brcmstb-rescal: fix incorrect polarity of status bit
Browse files Browse the repository at this point in the history
The readl_poll_timeout() should complete when the status bit
is a 1, not 0.

Fixes: 4cf176e ("reset: Add Broadcom STB RESCAL reset controller")
Signed-off-by: Jim Quinlan <jim2101024@gmail.com>
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Link: https://lore.kernel.org/r/20210914221122.62315-1-f.fainelli@gmail.com
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
  • Loading branch information
Jim Quinlan authored and Philipp Zabel committed Oct 5, 2021
1 parent 6880fa6 commit f33eb7f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/reset/reset-brcmstb-rescal.c
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ static int brcm_rescal_reset_set(struct reset_controller_dev *rcdev,
}

ret = readl_poll_timeout(base + BRCM_RESCAL_STATUS, reg,
!(reg & BRCM_RESCAL_STATUS_BIT), 100, 1000);
(reg & BRCM_RESCAL_STATUS_BIT), 100, 1000);
if (ret) {
dev_err(data->dev, "time out on SATA/PCIe rescal\n");
return ret;
Expand Down

0 comments on commit f33eb7f

Please sign in to comment.