Skip to content

Commit

Permalink
rose: Wrong list_lock argument in rose_node seqops
Browse files Browse the repository at this point in the history
In rose_node_start() as well as in rose_node_stop() __acquires() and
spin_lock_bh() were wrongly passing rose_neigh_list_lock instead of
rose_node_list_lock arguments.

Signed-off-by: Bernard Pidoux <f6bvp@amsat.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Bernard Pidoux authored and David S. Miller committed May 3, 2008
1 parent 4ac2ccd commit f37f2c6
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions net/rose/rose_route.c
Original file line number Diff line number Diff line change
Expand Up @@ -1066,12 +1066,12 @@ int rose_route_frame(struct sk_buff *skb, ax25_cb *ax25)
#ifdef CONFIG_PROC_FS

static void *rose_node_start(struct seq_file *seq, loff_t *pos)
__acquires(rose_neigh_list_lock)
__acquires(rose_node_list_lock)
{
struct rose_node *rose_node;
int i = 1;

spin_lock_bh(&rose_neigh_list_lock);
spin_lock_bh(&rose_node_list_lock);
if (*pos == 0)
return SEQ_START_TOKEN;

Expand All @@ -1090,9 +1090,9 @@ static void *rose_node_next(struct seq_file *seq, void *v, loff_t *pos)
}

static void rose_node_stop(struct seq_file *seq, void *v)
__releases(rose_neigh_list_lock)
__releases(rose_node_list_lock)
{
spin_unlock_bh(&rose_neigh_list_lock);
spin_unlock_bh(&rose_node_list_lock);
}

static int rose_node_show(struct seq_file *seq, void *v)
Expand Down

0 comments on commit f37f2c6

Please sign in to comment.