Skip to content

Commit

Permalink
net:ethernet:cadence: Replace dev_kfree_skb_any by dev_consume_skb_any
Browse files Browse the repository at this point in the history
The skb should be freed by dev_consume_skb_any() in macb_pad_and_fcs()
when *skb is still used. The *skb is be replaced by nskb, so the
original *skb should be consumed(not drop).

Signed-off-by: Huang Zijiang <huang.zijiang@zte.com.cn>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Huang Zijiang authored and David S. Miller committed Feb 14, 2019
1 parent 62f2589 commit f3e5c07
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/net/ethernet/cadence/macb_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -1734,7 +1734,7 @@ static int macb_pad_and_fcs(struct sk_buff **skb, struct net_device *ndev)
if (!nskb)
return -ENOMEM;

dev_kfree_skb_any(*skb);
dev_consume_skb_any(*skb);
*skb = nskb;
}

Expand Down

0 comments on commit f3e5c07

Please sign in to comment.