Skip to content

Commit

Permalink
usb: cdns3: gadget: Don't manage pullups
Browse files Browse the repository at this point in the history
The USB gadget core is supposed to manage pullups
of the controller. Don't manage pullups from within
the controller driver. Otherwise, function drivers
are not able to keep the controller disconnected from
the bus till they are ready. (e.g. g_webcam)

Reviewed-by: Pawel Laszczak <pawell@cadence.com>
Signed-off-by: Roger Quadros <rogerq@ti.com>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
  • Loading branch information
Roger Quadros authored and Felipe Balbi committed Oct 27, 2019
1 parent a7d9874 commit f3fb802
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions drivers/usb/cdns3/gadget.c
Original file line number Diff line number Diff line change
Expand Up @@ -2329,8 +2329,6 @@ static void cdns3_gadget_config(struct cdns3_device *priv_dev)
writel(USB_CONF_CLK2OFFDS | USB_CONF_L1DS, &regs->usb_conf);

cdns3_configure_dmult(priv_dev, NULL);

cdns3_gadget_pullup(&priv_dev->gadget, 1);
}

/**
Expand Down Expand Up @@ -2713,8 +2711,6 @@ static int cdns3_gadget_suspend(struct cdns3 *cdns, bool do_wakeup)
/* disable interrupt for device */
writel(0, &priv_dev->regs->usb_ien);

cdns3_gadget_pullup(&priv_dev->gadget, 0);

return 0;
}

Expand Down

0 comments on commit f3fb802

Please sign in to comment.