Skip to content

Commit

Permalink
remoteproc: fix memory leak of remoteproc ida cache layers
Browse files Browse the repository at this point in the history
The remoteproc core uses a static ida named rproc_dev_index for
assigning an automatic index number to a registered remoteproc.
The ida core may allocate some internal idr cache layers and ida
bitmap upon any ida allocation, and all these layers are truely
freed only upon the ida destruction. The rproc_dev_index ida is
not destroyed at present, leading to a memory leak when using the
remoteproc core as a module and atleast one rproc device is
registered and unregistered.

Fix this by invoking ida_destroy() in the remoteproc core module
exit.

Signed-off-by: Suman Anna <s-anna@ti.com>
Signed-off-by: Ohad Ben-Cohen <ohad@wizery.com>
  • Loading branch information
Suman Anna authored and Ohad Ben-Cohen committed Nov 26, 2015
1 parent 92792e4 commit f42f79a
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions drivers/remoteproc/remoteproc_core.c
Original file line number Diff line number Diff line change
Expand Up @@ -1478,6 +1478,8 @@ module_init(remoteproc_init);

static void __exit remoteproc_exit(void)
{
ida_destroy(&rproc_dev_index);

rproc_exit_debugfs();
}
module_exit(remoteproc_exit);
Expand Down

0 comments on commit f42f79a

Please sign in to comment.