Skip to content

Commit

Permalink
coresight-tpdm: Remove the unnecessary lock
Browse files Browse the repository at this point in the history
Remove the unnecessary lock "CS_{UN,}LOCK" in TPDM driver. This
lock is only needed while writing the data to Coresight registers.

Signed-off-by: Tao Zhang <quic_taozha@quicinc.com>
Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
Link: https://lore.kernel.org/r/1695882586-10306-2-git-send-email-quic_taozha@quicinc.com
  • Loading branch information
Tao Zhang authored and Suzuki K Poulose committed Nov 16, 2023
1 parent 2373699 commit f4443ee
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions drivers/hwtracing/coresight/coresight-tpdm.c
Original file line number Diff line number Diff line change
Expand Up @@ -114,11 +114,9 @@ static void tpdm_init_default_data(struct tpdm_drvdata *drvdata)
{
u32 pidr;

CS_UNLOCK(drvdata->base);
/* Get the datasets present on the TPDM. */
pidr = readl_relaxed(drvdata->base + CORESIGHT_PERIPHIDR0);
drvdata->datasets |= pidr & GENMASK(TPDM_DATASETS - 1, 0);
CS_LOCK(drvdata->base);
}

/*
Expand Down

0 comments on commit f4443ee

Please sign in to comment.