Skip to content

Commit

Permalink
ext4: missing unlock in ext4_clear_request_list()
Browse files Browse the repository at this point in the history
If the the li_request_list was empty then it returned with the lock
held.  Instead of adding a "goto unlock" I just removed that special
case and let it go past the empty list_for_each_safe().

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
  • Loading branch information
Dan Carpenter authored and Theodore Ts'o committed Nov 18, 2010
1 parent 08da119 commit f4c8cc6
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions fs/ext4/super.c
Original file line number Diff line number Diff line change
Expand Up @@ -2799,9 +2799,6 @@ static void ext4_clear_request_list(void)
struct ext4_li_request *elr;

mutex_lock(&ext4_li_info->li_list_mtx);
if (list_empty(&ext4_li_info->li_request_list))
return;

list_for_each_safe(pos, n, &ext4_li_info->li_request_list) {
elr = list_entry(pos, struct ext4_li_request,
lr_request);
Expand Down

0 comments on commit f4c8cc6

Please sign in to comment.