Skip to content

Commit

Permalink
drm/omapdrm: Use backlight_enable/disable helpers
Browse files Browse the repository at this point in the history
Use backlight_enable/disable helpers instead of changing
the property and calling backlight_update_status for cleaner
and simpler code and also to avoid repetitions.

Reviewed-by: Noralf Trønnes <noralf@tronnes.org>
Reviewed-by: Sean Paul <seanpaul@chromium.org>
Signed-off-by: Meghana Madhyastha <meghana.madhyastha@gmail.com>
Signed-off-by: Sean Paul <seanpaul@chromium.org>
Link: https://patchwork.freedesktop.org/patch/msgid/30d5b26c3c7d75de3d2ab3cff9dee67084fc3caf.1516810725.git.meghana.madhyastha@gmail.com
  • Loading branch information
Meghana Madhyastha authored and Sean Paul committed Feb 20, 2018
1 parent d593bfd commit f4ccc2b
Showing 1 changed file with 2 additions and 9 deletions.
11 changes: 2 additions & 9 deletions drivers/gpu/drm/omapdrm/displays/panel-dpi.c
Original file line number Diff line number Diff line change
Expand Up @@ -87,11 +87,7 @@ static int panel_dpi_enable(struct omap_dss_device *dssdev)
}

gpiod_set_value_cansleep(ddata->enable_gpio, 1);

if (ddata->backlight) {
ddata->backlight->props.power = FB_BLANK_UNBLANK;
backlight_update_status(ddata->backlight);
}
backlight_enable(ddata->backlight);

dssdev->state = OMAP_DSS_DISPLAY_ACTIVE;

Expand All @@ -106,10 +102,7 @@ static void panel_dpi_disable(struct omap_dss_device *dssdev)
if (!omapdss_device_is_enabled(dssdev))
return;

if (ddata->backlight) {
ddata->backlight->props.power = FB_BLANK_POWERDOWN;
backlight_update_status(ddata->backlight);
}
backlight_disable(ddata->backlight);

gpiod_set_value_cansleep(ddata->enable_gpio, 0);
regulator_disable(ddata->vcc_supply);
Expand Down

0 comments on commit f4ccc2b

Please sign in to comment.