Skip to content

Commit

Permalink
ASoC: omap: rx51: Fix enum ctl accesses in a wrong type
Browse files Browse the repository at this point in the history
"Speaker Function", "Input Select" and "Jack Function" ctls in rx51
driver are enum, while the current driver accesses wrongly via
value.integer.value[].  They have to be via value.enumerated.item[]
instead.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
Acked-by: Jarkko Nikula <jarkko.nikula@bitmer.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
  • Loading branch information
Takashi Iwai authored and Mark Brown committed Mar 1, 2016
1 parent dd90533 commit f4d438e
Showing 1 changed file with 9 additions and 9 deletions.
18 changes: 9 additions & 9 deletions sound/soc/omap/rx51.c
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ static struct snd_soc_ops rx51_ops = {
static int rx51_get_spk(struct snd_kcontrol *kcontrol,
struct snd_ctl_elem_value *ucontrol)
{
ucontrol->value.integer.value[0] = rx51_spk_func;
ucontrol->value.enumerated.item[0] = rx51_spk_func;

return 0;
}
Expand All @@ -142,10 +142,10 @@ static int rx51_set_spk(struct snd_kcontrol *kcontrol,
{
struct snd_soc_card *card = snd_kcontrol_chip(kcontrol);

if (rx51_spk_func == ucontrol->value.integer.value[0])
if (rx51_spk_func == ucontrol->value.enumerated.item[0])
return 0;

rx51_spk_func = ucontrol->value.integer.value[0];
rx51_spk_func = ucontrol->value.enumerated.item[0];
rx51_ext_control(&card->dapm);

return 1;
Expand Down Expand Up @@ -180,7 +180,7 @@ static int rx51_hp_event(struct snd_soc_dapm_widget *w,
static int rx51_get_input(struct snd_kcontrol *kcontrol,
struct snd_ctl_elem_value *ucontrol)
{
ucontrol->value.integer.value[0] = rx51_dmic_func;
ucontrol->value.enumerated.item[0] = rx51_dmic_func;

return 0;
}
Expand All @@ -190,10 +190,10 @@ static int rx51_set_input(struct snd_kcontrol *kcontrol,
{
struct snd_soc_card *card = snd_kcontrol_chip(kcontrol);

if (rx51_dmic_func == ucontrol->value.integer.value[0])
if (rx51_dmic_func == ucontrol->value.enumerated.item[0])
return 0;

rx51_dmic_func = ucontrol->value.integer.value[0];
rx51_dmic_func = ucontrol->value.enumerated.item[0];
rx51_ext_control(&card->dapm);

return 1;
Expand All @@ -202,7 +202,7 @@ static int rx51_set_input(struct snd_kcontrol *kcontrol,
static int rx51_get_jack(struct snd_kcontrol *kcontrol,
struct snd_ctl_elem_value *ucontrol)
{
ucontrol->value.integer.value[0] = rx51_jack_func;
ucontrol->value.enumerated.item[0] = rx51_jack_func;

return 0;
}
Expand All @@ -212,10 +212,10 @@ static int rx51_set_jack(struct snd_kcontrol *kcontrol,
{
struct snd_soc_card *card = snd_kcontrol_chip(kcontrol);

if (rx51_jack_func == ucontrol->value.integer.value[0])
if (rx51_jack_func == ucontrol->value.enumerated.item[0])
return 0;

rx51_jack_func = ucontrol->value.integer.value[0];
rx51_jack_func = ucontrol->value.enumerated.item[0];
rx51_ext_control(&card->dapm);

return 1;
Expand Down

0 comments on commit f4d438e

Please sign in to comment.