Skip to content

Commit

Permalink
Revert "drm/msm: cleanup: drm_modeset_lock_all_ctx() --> DRM_MODESET_…
Browse files Browse the repository at this point in the history
…LOCK_ALL_BEGIN()"

This reverts commit 4c04843.

This patchset breaks on intel platforms and was previously NACK'd by
Ville.

Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Fernando Ramos <greenfoo@u92.eu>
Acked-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Sean Paul <seanpaul@chromium.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20211002154542.15800-14-sean@poorly.run
  • Loading branch information
Sean Paul committed Oct 4, 2021
1 parent 76fd2c3 commit f505495
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions drivers/gpu/drm/msm/disp/msm_disp_snapshot_util.c
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,6 @@

#define pr_fmt(fmt) "[drm:%s:%d] " fmt, __func__, __LINE__

#include <drm/drm_drv.h>

#include "msm_disp_snapshot.h"

static void msm_disp_state_dump_regs(u32 **reg, u32 aligned_len, void __iomem *base_addr)
Expand Down Expand Up @@ -101,18 +99,20 @@ static void msm_disp_capture_atomic_state(struct msm_disp_state *disp_state)
{
struct drm_device *ddev;
struct drm_modeset_acquire_ctx ctx;
int ret;

disp_state->timestamp = ktime_get();

ddev = disp_state->drm_dev;

DRM_MODESET_LOCK_ALL_BEGIN(ddev, ctx, 0, ret);
drm_modeset_acquire_init(&ctx, 0);

while (drm_modeset_lock_all_ctx(ddev, &ctx) != 0)
drm_modeset_backoff(&ctx);

disp_state->atomic_state = drm_atomic_helper_duplicate_state(ddev,
&ctx);

DRM_MODESET_LOCK_ALL_END(ddev, ctx, ret);
drm_modeset_drop_locks(&ctx);
drm_modeset_acquire_fini(&ctx);
}

void msm_disp_snapshot_capture_state(struct msm_disp_state *disp_state)
Expand Down

0 comments on commit f505495

Please sign in to comment.