Skip to content

Commit

Permalink
net: dsa: mv88e6xxx: set 802.1Q mode to Fallback
Browse files Browse the repository at this point in the history
The current Secure port mode requires the port-based VLANs to also be
valid in the 802.1Q VLAN Table Unit. The current hardware bridging
support only configures the port-based VLANs, thus is broken.

A new patchset is required to adapt the hardware bridging code to fully
support the Secure port mode.

In the meantime, change the 802.1Q mode of every ports to Fallback,
which filtering is more permissive, and doesn't add this restriction to
handle port-based and tagged-based VLANs.

Fixes: 8efdda4 ("net: dsa: mv88e6xxx: use port 802.1Q mode Secure")
Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Vivien Didelot authored and David S. Miller committed Aug 23, 2015
1 parent dc25b25 commit f5117ce
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/net/dsa/mv88e6xxx.c
Original file line number Diff line number Diff line change
Expand Up @@ -2033,7 +2033,7 @@ static int mv88e6xxx_setup_port(struct dsa_switch *ds, int port)
reg |= PORT_CONTROL_2_FORWARD_UNKNOWN;
}

reg |= PORT_CONTROL_2_8021Q_SECURE;
reg |= PORT_CONTROL_2_8021Q_FALLBACK;

if (reg) {
ret = _mv88e6xxx_reg_write(ds, REG_PORT(port),
Expand Down

0 comments on commit f5117ce

Please sign in to comment.