Skip to content

Commit

Permalink
wifi: mac80211: reject per-band vendor elements with MLO
Browse files Browse the repository at this point in the history
The MLME code doesn't currently handle adding vendor elements
correctly with multi-link due to element inheritance. Simply
prevent that for now completely, if someone needs it we can
fix this later.

Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Miri Korenblit <miriam.rachel.korenblit@intel.com>
Link: https://patch.msgid.link/20250101070249.bb82d3aaf6ef.Ib30573d0666430a3d7a905e513dfc661edf0bf65@changeid
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
  • Loading branch information
Johannes Berg committed Jan 13, 2025
1 parent dfd5b5b commit f52de50
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions net/mac80211/main.c
Original file line number Diff line number Diff line change
Expand Up @@ -1310,6 +1310,11 @@ int ieee80211_register_hw(struct ieee80211_hw *hw)
sband->ht_cap.cap & IEEE80211_HT_CAP_SUP_WIDTH_20_40 &&
!(iftd->he_cap.he_cap_elem.phy_cap_info[0] & he_40_mhz_cap))
return -EINVAL;

/* no support for per-band vendor elems with MLO */
if (WARN_ON(iftd->vendor_elems.len &&
hw->wiphy->flags & WIPHY_FLAG_SUPPORTS_MLO))
return -EINVAL;
}

/* HT, VHT, HE require QoS, thus >= 4 queues */
Expand Down

0 comments on commit f52de50

Please sign in to comment.