Skip to content

Commit

Permalink
selftests/hid: fix ruff linter complains
Browse files Browse the repository at this point in the history
rename ambiguous variables l, r, and m, and ignore the return values
of uhdev.get_evdev() and uhdev.get_slot()

Acked-by: Jiri Kosina <jkosina@suse.com>
Link: https://lore.kernel.org/r/20231206-wip-selftests-v2-15-c0350c2f5986@kernel.org
Signed-off-by: Benjamin Tissoires <bentiss@kernel.org>
  • Loading branch information
Benjamin Tissoires committed Dec 7, 2023
1 parent ed5bc56 commit f556aa9
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 10 deletions.
14 changes: 7 additions & 7 deletions tools/testing/selftests/hid/tests/test_mouse.py
Original file line number Diff line number Diff line change
Expand Up @@ -52,13 +52,13 @@ def create_report(self, x, y, buttons=None, wheels=None, reportID=None):
:param reportID: the numeric report ID for this report, if needed
"""
if buttons is not None:
l, r, m = buttons
if l is not None:
self.left = l
if r is not None:
self.right = r
if m is not None:
self.middle = m
left, right, middle = buttons
if left is not None:
self.left = left
if right is not None:
self.right = right
if middle is not None:
self.middle = middle
left = self.left
right = self.right
middle = self.middle
Expand Down
6 changes: 3 additions & 3 deletions tools/testing/selftests/hid/tests/test_wacom_generic.py
Original file line number Diff line number Diff line change
Expand Up @@ -909,14 +909,14 @@ def test_confidence_false(self):
Ensure that the confidence bit being set to false should not result in a touch event.
"""
uhdev = self.uhdev
evdev = uhdev.get_evdev()
_evdev = uhdev.get_evdev()

t0 = test_multitouch.Touch(1, 50, 100)
t0.confidence = False
r = uhdev.event([t0])
events = uhdev.next_sync_events()
self.debug_reports(r, uhdev, events)

slot = self.get_slot(uhdev, t0, 0)
_slot = self.get_slot(uhdev, t0, 0)

assert not events
assert not events

0 comments on commit f556aa9

Please sign in to comment.