Skip to content

Commit

Permalink
ASoC: tlv320aic23: remove incorrect __exit markups
Browse files Browse the repository at this point in the history
Even if bus is not hot-pluggable, the devices can be unbound from the
driver via sysfs, so we should not be using __exit annotations on
remove() methods. The only exception is drivers registered with
platform_driver_probe() which specifically disables sysfs bind/unbind
attributes.

Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
  • Loading branch information
Dmitry Torokhov authored and Mark Brown committed Mar 9, 2015
1 parent c517d83 commit f580f8a
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions sound/soc/codecs/tlv320aic23-i2c.c
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ static int tlv320aic23_i2c_probe(struct i2c_client *i2c,
return tlv320aic23_probe(&i2c->dev, regmap);
}

static int __exit tlv320aic23_i2c_remove(struct i2c_client *i2c)
static int tlv320aic23_i2c_remove(struct i2c_client *i2c)
{
snd_soc_unregister_codec(&i2c->dev);
return 0;
Expand All @@ -56,7 +56,7 @@ static struct i2c_driver tlv320aic23_i2c_driver = {
.of_match_table = of_match_ptr(tlv320aic23_of_match),
},
.probe = tlv320aic23_i2c_probe,
.remove = __exit_p(tlv320aic23_i2c_remove),
.remove = tlv320aic23_i2c_remove,
.id_table = tlv320aic23_id,
};

Expand Down

0 comments on commit f580f8a

Please sign in to comment.