Skip to content

Commit

Permalink
net_sched: info leak in atm_tc_dump_class()
Browse files Browse the repository at this point in the history
[ Upstream commit 8cb3b9c ]

The "pvc" struct has a hole after pvc.sap_family which is not cleared.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Jiri Pirko <jiri@resnulli.us>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Willy Tarreau <w@1wt.eu>
  • Loading branch information
Dan Carpenter authored and Willy Tarreau committed May 19, 2014
1 parent f084fd3 commit f5a2119
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions net/sched/sch_atm.c
Original file line number Diff line number Diff line change
Expand Up @@ -628,6 +628,7 @@ static int atm_tc_dump_class(struct Qdisc *sch, unsigned long cl,
struct sockaddr_atmpvc pvc;
int state;

memset(&pvc, 0, sizeof(pvc));
pvc.sap_family = AF_ATMPVC;
pvc.sap_addr.itf = flow->vcc->dev ? flow->vcc->dev->number : -1;
pvc.sap_addr.vpi = flow->vcc->vpi;
Expand Down

0 comments on commit f5a2119

Please sign in to comment.