Skip to content

Commit

Permalink
scsi: elx: libefc_sli: Fix ANDing with zero bit value
Browse files Browse the repository at this point in the history
Flags value is being set to a constant and ANDed with 0 which always
results in 0.

Remove the assignment line.

Link: https://lore.kernel.org/r/20210619155641.19942-1-jsmart2021@gmail.com
Fixes: 1628f5b ("scsi: elx: libefc_sli: Populate and post different WQEs")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Co-developed-by: Ram Vegesna <ram.vegesna@broadcom.com>
Signed-off-by: Ram Vegesna <ram.vegesna@broadcom.com>
Signed-off-by: James Smart <james.smart@broadcom.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
  • Loading branch information
James Smart authored and Martin K. Petersen committed Jun 23, 2021
1 parent 041761f commit f6060eb
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions drivers/scsi/elx/libefc_sli/sli4.c
Original file line number Diff line number Diff line change
Expand Up @@ -2381,8 +2381,6 @@ sli_xmit_els_rsp64_wqe(struct sli4 *sli, void *buf, struct efc_dma *rsp,

els->ox_id = cpu_to_le16(params->ox_id);

els->flags2 |= SLI4_ELS_IOD & SLI4_ELS_REQUEST64_DIR_WRITE;

els->flags2 |= SLI4_ELS_QOSD;

els->cmd_type_wqec = SLI4_ELS_REQUEST64_CMD_GEN;
Expand Down

0 comments on commit f6060eb

Please sign in to comment.