Skip to content

Commit

Permalink
workqueue: workqueue_cpu_callback() should be cpu_notifier instead of…
Browse files Browse the repository at this point in the history
… hotcpu_notifier

Commit 6ee0578 (workqueue: mark init_workqueues as early_initcall)
made workqueue SMP initialization depend on workqueue_cpu_callback(),
which however was registered as hotcpu_notifier() and didn't get
called if CONFIG_HOTPLUG_CPU is not set.  This made gcwqs on non-boot
CPUs not create their initial workers leading to boot failures.  Fix
it by making it a cpu_notifier.

Signed-off-by: Tejun Heo <tj@kernel.org>
Reported-and-bisected-by: walt <w41ter@gmail.com>
Tested-by: Markus Trippelsdorf <markus@trippelsdorf.de>
  • Loading branch information
Tejun Heo committed Aug 9, 2010
1 parent 38f5156 commit f650094
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion kernel/workqueue.c
Original file line number Diff line number Diff line change
Expand Up @@ -3527,7 +3527,7 @@ static int __init init_workqueues(void)
unsigned int cpu;
int i;

hotcpu_notifier(workqueue_cpu_callback, CPU_PRI_WORKQUEUE);
cpu_notifier(workqueue_cpu_callback, CPU_PRI_WORKQUEUE);

/* initialize gcwqs */
for_each_gcwq_cpu(cpu) {
Expand Down

0 comments on commit f650094

Please sign in to comment.