Skip to content

Commit

Permalink
ACPI / PM: Drop acpi_bus_get_power()
Browse files Browse the repository at this point in the history
There are no more users of acpi_bus_get_power(), so it can be
dropped.  Moreover, it should be dropped, because it modifies
the device->power.state field of an ACPI device without updating
the reference counters of the device's power resources, which is
wrong.

Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
Signed-off-by: Len Brown <len.brown@intel.com>
  • Loading branch information
Rafael J. Wysocki authored and Len Brown committed Jan 12, 2011
1 parent 40b7397 commit f6767dc
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 20 deletions.
19 changes: 0 additions & 19 deletions drivers/acpi/bus.c
Original file line number Diff line number Diff line change
Expand Up @@ -236,25 +236,6 @@ static int __acpi_bus_get_power(struct acpi_device *device, int *state)
}


int acpi_bus_get_power(acpi_handle handle, int *state)
{
struct acpi_device *device;
int result;

result = acpi_bus_get_device(handle, &device);
if (result)
return result;

result = __acpi_bus_get_power(device, state);
if (result)
return result;

device->power.state = *state;
return 0;
}
EXPORT_SYMBOL(acpi_bus_get_power);


static int __acpi_bus_set_power(struct acpi_device *device, int state)
{
int result = 0;
Expand Down
1 change: 0 additions & 1 deletion include/acpi/acpi_bus.h
Original file line number Diff line number Diff line change
Expand Up @@ -327,7 +327,6 @@ void acpi_bus_data_handler(acpi_handle handle, void *context);
acpi_status acpi_bus_get_status_handle(acpi_handle handle,
unsigned long long *sta);
int acpi_bus_get_status(struct acpi_device *device);
int acpi_bus_get_power(acpi_handle handle, int *state);
int acpi_bus_set_power(acpi_handle handle, int state);
int acpi_bus_update_power(acpi_handle handle, int *state_p);
bool acpi_bus_power_manageable(acpi_handle handle);
Expand Down

0 comments on commit f6767dc

Please sign in to comment.