Skip to content

Commit

Permalink
drm/amd/display: fix a regression in blank pixel data caused by codin…
Browse files Browse the repository at this point in the history
…g mistake

[why]
There was unfortunately a coding mistake. It gets caught with an ultrawide monitor
that requires ODM 4:1 combine. We are blanking or unblanking pixel data we
are supposed to enumerate through all ODM pipes and program DPG for each
of those pipes. However the coding mistake causes us to program only the
first and last ODM pipes.

Cc: Mario Limonciello <mario.limonciello@amd.com>
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: stable@vger.kernel.org
Reviewed-by: Martin Leung <martin.leung@amd.com>
Acked-by: Tom Chung <chiahsuan.chung@amd.com>
Signed-off-by: Wenjing Liu <wenjing.liu@amd.com>
Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
  • Loading branch information
Wenjing Liu authored and Alex Deucher committed Aug 7, 2023
1 parent 664c3b0 commit f77d1a4
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion drivers/gpu/drm/amd/display/dc/dcn20/dcn20_hwseq.c
Original file line number Diff line number Diff line change
Expand Up @@ -1084,7 +1084,7 @@ void dcn20_blank_pixel_data(

while (odm_pipe->next_odm_pipe) {
dc->hwss.set_disp_pattern_generator(dc,
pipe_ctx,
odm_pipe,
test_pattern,
test_pattern_color_space,
stream->timing.display_color_depth,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -513,7 +513,7 @@ static void set_crtc_test_pattern(struct dc_link *link,
odm_opp = odm_pipe->stream_res.opp;
odm_opp->funcs->opp_program_bit_depth_reduction(odm_opp, &params);
link->dc->hwss.set_disp_pattern_generator(link->dc,
pipe_ctx,
odm_pipe,
controller_test_pattern,
controller_color_space,
color_depth,
Expand Down

0 comments on commit f77d1a4

Please sign in to comment.