Skip to content

Commit

Permalink
platform/x86: dell-laptop: Drop superfluous exported function
Browse files Browse the repository at this point in the history
Since we've switched to the LED trigger for binding with HD-audio,
we can drop the exported function as well as the whole
linux/dell-led.h.

Acked-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
Acked-by: Pavel Machek <pavel@ucw.cz>
Acked-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Acked-by: Pali Rohár <pali.rohar@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
  • Loading branch information
Takashi Iwai committed Nov 28, 2018
1 parent b380278 commit f783e12
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 24 deletions.
22 changes: 5 additions & 17 deletions drivers/platform/x86/dell-laptop.c
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@
#include <linux/mm.h>
#include <linux/i8042.h>
#include <linux/debugfs.h>
#include <linux/dell-led.h>
#include <linux/seq_file.h>
#include <acpi/video.h>
#include "dell-rbtn.h"
Expand Down Expand Up @@ -2109,36 +2108,25 @@ static struct notifier_block dell_laptop_notifier = {
.notifier_call = dell_laptop_notifier_call,
};

int dell_micmute_led_set(int state)
static int micmute_led_set(struct led_classdev *led_cdev,
enum led_brightness brightness)
{
struct calling_interface_buffer buffer;
struct calling_interface_token *token;
int state = brightness != LED_OFF;

if (state == 0)
token = dell_smbios_find_token(GLOBAL_MIC_MUTE_DISABLE);
else if (state == 1)
token = dell_smbios_find_token(GLOBAL_MIC_MUTE_ENABLE);
else
return -EINVAL;
token = dell_smbios_find_token(GLOBAL_MIC_MUTE_ENABLE);

if (!token)
return -ENODEV;

dell_fill_request(&buffer, token->location, token->value, 0, 0);
dell_send_request(&buffer, CLASS_TOKEN_WRITE, SELECT_TOKEN_STD);

return state;
}
EXPORT_SYMBOL_GPL(dell_micmute_led_set);

static int micmute_led_set(struct led_classdev *led_cdev,
enum led_brightness brightness)
{
int state = brightness != LED_OFF;
int err;

err = dell_micmute_led_set(state);
return err < 0 ? err : 0;
return 0;
}

static struct led_classdev micmute_led_cdev = {
Expand Down
7 changes: 0 additions & 7 deletions include/linux/dell-led.h

This file was deleted.

0 comments on commit f783e12

Please sign in to comment.