Skip to content

Commit

Permalink
ASoC: cpcap: Check for NULL pointer after calling of_get_child_by_name
Browse files Browse the repository at this point in the history
If the device does not exist, of_get_child_by_name() will return NULL
pointer.
And devm_snd_soc_register_component() does not check it.
Also, I have noticed that cpcap_codec_driver has not been used yet.
Therefore, it should be better to check it in order to avoid the future
dereference of the NULL pointer.

Fixes: f6cdf2d ("ASoC: cpcap: new codec")
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
Link: https://lore.kernel.org/r/20220111025048.524134-1-jiasheng@iscas.ac.cn
Signed-off-by: Mark Brown <broonie@kernel.org>
  • Loading branch information
Jiasheng Jiang authored and Mark Brown committed Jan 12, 2022
1 parent a64067f commit f7a6021
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions sound/soc/codecs/cpcap.c
Original file line number Diff line number Diff line change
Expand Up @@ -1667,6 +1667,8 @@ static int cpcap_codec_probe(struct platform_device *pdev)
{
struct device_node *codec_node =
of_get_child_by_name(pdev->dev.parent->of_node, "audio-codec");
if (!codec_node)
return -ENODEV;

pdev->dev.of_node = codec_node;

Expand Down

0 comments on commit f7a6021

Please sign in to comment.