Skip to content

Commit

Permalink
net: mhi: Fix memory leak in mhi_net_dellink()
Browse files Browse the repository at this point in the history
MHI driver registers network device without setting the
needs_free_netdev flag, and does NOT call free_netdev() when
unregisters network device, which causes a memory leak.

This patch calls free_netdev() to fix it since netdev_priv
is used after unregister.

Fixes: 13adac0 ("net: mhi_net: Register wwan_ops for link creation")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Wei Yongjun authored and David S. Miller committed Nov 14, 2022
1 parent 3738d48 commit f7c125b
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions drivers/net/mhi_net.c
Original file line number Diff line number Diff line change
Expand Up @@ -343,6 +343,8 @@ static void mhi_net_dellink(struct mhi_device *mhi_dev, struct net_device *ndev)

kfree_skb(mhi_netdev->skbagg_head);

free_netdev(ndev);

dev_set_drvdata(&mhi_dev->dev, NULL);
}

Expand Down

0 comments on commit f7c125b

Please sign in to comment.