Skip to content

Commit

Permalink
ASoC: Intel: avs: Expose FW version with sysfs
Browse files Browse the repository at this point in the history
Add functionality to read version of loaded FW from sysfs.

Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com>
Signed-off-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>
Link: https://lore.kernel.org/r/20240209085256.121261-1-amadeuszx.slawinski@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
  • Loading branch information
Cezary Rojewski authored and Mark Brown committed Feb 9, 2024
1 parent 4089d82 commit f7fc624
Show file tree
Hide file tree
Showing 5 changed files with 50 additions and 1 deletion.
8 changes: 8 additions & 0 deletions Documentation/ABI/testing/sysfs-bus-pci-devices-avs
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
What: /sys/devices/pci0000:00/<dev>/avs/fw_version
Date: February 2024
Contact: Cezary Rojewski <cezary.rojewski@intel.com>
Description:
Version of AudioDSP firmware ASoC avs driver is communicating
with.

Format: %d.%d.%d.%d, type:major:minor:build.
3 changes: 2 additions & 1 deletion sound/soc/intel/avs/Makefile
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
# SPDX-License-Identifier: GPL-2.0-only

snd-soc-avs-objs := dsp.o ipc.o messages.o utils.o core.o loader.o \
topology.o path.o pcm.o board_selection.o control.o
topology.o path.o pcm.o board_selection.o control.o \
sysfs.o
snd-soc-avs-objs += cldma.o
snd-soc-avs-objs += skl.o apl.o

Expand Down
4 changes: 4 additions & 0 deletions sound/soc/intel/avs/avs.h
Original file line number Diff line number Diff line change
Expand Up @@ -392,4 +392,8 @@ static inline void avs_debugfs_init(struct avs_dev *adev) { }
static inline void avs_debugfs_exit(struct avs_dev *adev) { }
#endif

/* Filesystems integration */

extern const struct attribute_group *avs_attr_groups[];

#endif /* __SOUND_SOC_INTEL_AVS_H */
1 change: 1 addition & 0 deletions sound/soc/intel/avs/core.c
Original file line number Diff line number Diff line change
Expand Up @@ -773,6 +773,7 @@ static struct pci_driver avs_pci_driver = {
.probe = avs_pci_probe,
.remove = avs_pci_remove,
.shutdown = avs_pci_shutdown,
.dev_groups = avs_attr_groups,
.driver = {
.pm = &avs_dev_pm,
},
Expand Down
35 changes: 35 additions & 0 deletions sound/soc/intel/avs/sysfs.c
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
// SPDX-License-Identifier: GPL-2.0-only
//
// Copyright(c) 2021-2024 Intel Corporation. All rights reserved.
//
// Authors: Cezary Rojewski <cezary.rojewski@intel.com>
// Amadeusz Slawinski <amadeuszx.slawinski@linux.intel.com>
//

#include <linux/sysfs.h>
#include "avs.h"

static ssize_t fw_version_show(struct device *dev, struct device_attribute *attr, char *buf)
{
struct avs_dev *adev = to_avs_dev(dev);
struct avs_fw_version *fw_version = &adev->fw_cfg.fw_version;

return sysfs_emit(buf, "%d.%d.%d.%d\n", fw_version->major, fw_version->minor,
fw_version->hotfix, fw_version->build);
}
static DEVICE_ATTR_RO(fw_version);

static struct attribute *avs_fw_attrs[] = {
&dev_attr_fw_version.attr,
NULL
};

static const struct attribute_group avs_attr_group = {
.name = "avs",
.attrs = avs_fw_attrs,
};

const struct attribute_group *avs_attr_groups[] = {
&avs_attr_group,
NULL
};

0 comments on commit f7fc624

Please sign in to comment.