Skip to content

Commit

Permalink
tracing: append a comma to INIT_FTRACE_GRAPH
Browse files Browse the repository at this point in the history
Impact: dont break future extensions of INIT_TASK

While not a problem right now, due to lack of a comma, build fails if
elements are appended to INIT_TASK() macro in development code:

 arch/x86/kernel/init_task.c:33: error: request for member `XXXXXXXXXX' in something not a structure or union
 arch/x86/kernel/init_task.c:33: error: initializer element is not constant
 arch/x86/kernel/init_task.c:33: error: (near initialization for `init_task.ret_stack')
 make[1]: *** [arch/x86/kernel/init_task.o] Error 1
 make: *** [arch/x86/kernel] Error 2

Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: srostedt@redhat.com
LKML-Reference: <200904080505.n3855hcn017109@www262.sakura.ne.jp>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
  • Loading branch information
Tetsuo Handa authored and Ingo Molnar committed Apr 8, 2009
1 parent 577c9c4 commit f876d34
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion include/linux/ftrace.h
Original file line number Diff line number Diff line change
Expand Up @@ -357,7 +357,7 @@ struct ftrace_graph_ret {
#ifdef CONFIG_FUNCTION_GRAPH_TRACER

/* for init task */
#define INIT_FTRACE_GRAPH .ret_stack = NULL
#define INIT_FTRACE_GRAPH .ret_stack = NULL,

/*
* Stack of return addresses for functions
Expand Down

0 comments on commit f876d34

Please sign in to comment.