Skip to content

Commit

Permalink
ASoC: Augment existing card DAPM routes in snd_soc_of_parse_audio_rou…
Browse files Browse the repository at this point in the history
…ting

If a snd_soc_card has any DAPM routes when it calls
snd_soc_of_parse_audio_routing, those are clobbered without this change.

Signed-off-by: Peter Rosin <peda@axentia.se>
Signed-off-by: Mark Brown <broonie@kernel.org>
  • Loading branch information
Peter Rosin authored and Mark Brown committed Dec 4, 2014
1 parent 92a99ea commit f8781db
Showing 1 changed file with 9 additions and 5 deletions.
14 changes: 9 additions & 5 deletions sound/soc/soc-core.c
Original file line number Diff line number Diff line change
Expand Up @@ -4585,7 +4585,7 @@ int snd_soc_of_parse_audio_routing(struct snd_soc_card *card,
const char *propname)
{
struct device_node *np = card->dev->of_node;
int num_routes;
int num_routes, old_routes;
struct snd_soc_dapm_route *routes;
int i, ret;

Expand All @@ -4603,25 +4603,29 @@ int snd_soc_of_parse_audio_routing(struct snd_soc_card *card,
return -EINVAL;
}

routes = devm_kzalloc(card->dev, num_routes * sizeof(*routes),
old_routes = card->num_dapm_routes;
routes = devm_kzalloc(card->dev,
(old_routes + num_routes) * sizeof(*routes),
GFP_KERNEL);
if (!routes) {
dev_err(card->dev,
"ASoC: Could not allocate DAPM route table\n");
return -EINVAL;
}

memcpy(routes, card->dapm_routes, old_routes * sizeof(*routes));

for (i = 0; i < num_routes; i++) {
ret = of_property_read_string_index(np, propname,
2 * i, &routes[i].sink);
2 * i, &routes[old_routes + i].sink);
if (ret) {
dev_err(card->dev,
"ASoC: Property '%s' index %d could not be read: %d\n",
propname, 2 * i, ret);
return -EINVAL;
}
ret = of_property_read_string_index(np, propname,
(2 * i) + 1, &routes[i].source);
(2 * i) + 1, &routes[old_routes + i].source);
if (ret) {
dev_err(card->dev,
"ASoC: Property '%s' index %d could not be read: %d\n",
Expand All @@ -4630,7 +4634,7 @@ int snd_soc_of_parse_audio_routing(struct snd_soc_card *card,
}
}

card->num_dapm_routes = num_routes;
card->num_dapm_routes += num_routes;
card->dapm_routes = routes;

return 0;
Expand Down

0 comments on commit f8781db

Please sign in to comment.