Skip to content

Commit

Permalink
gpio: vr41xx: Bail out on gpiochip_lock_as_irq() error
Browse files Browse the repository at this point in the history
gpiochip_lock_as_irq() may return a few error codes,
bail out if it fails with corresponding returned code.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
  • Loading branch information
Andy Shevchenko authored and Linus Walleij committed Aug 6, 2018
1 parent d124339 commit f8ad8aa
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion drivers/gpio/gpio-vr41xx.c
Original file line number Diff line number Diff line change
Expand Up @@ -138,10 +138,16 @@ static void unmask_giuint_low(struct irq_data *d)

static unsigned int startup_giuint(struct irq_data *data)
{
if (gpiochip_lock_as_irq(&vr41xx_gpio_chip, data->hwirq))
int ret;

ret = gpiochip_lock_as_irq(&vr41xx_gpio_chip, irqd_to_hwirq(data));
if (ret) {
dev_err(vr41xx_gpio_chip.parent,
"unable to lock HW IRQ %lu for IRQ\n",
data->hwirq);
return ret;
}

/* Satisfy the .enable semantics by unmasking the line */
unmask_giuint_low(data);
return 0;
Expand Down

0 comments on commit f8ad8aa

Please sign in to comment.