Skip to content

Commit

Permalink
cpufreq/amd-pstate: Drop ret variable from amd_pstate_set_energy_pref…
Browse files Browse the repository at this point in the history
…_index()

The ret variable is not necessary.

Reviewed-and-tested-by: Dhananjay Ugwekar <dhananjay.ugwekar@amd.com>
Reviewed-by: Gautham R. Shenoy <gautham.shenoy@amd.com>
Link: https://lore.kernel.org/r/20241209185248.16301-14-mario.limonciello@amd.com
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
  • Loading branch information
Mario Limonciello committed Dec 11, 2024
1 parent fff3957 commit f8fde68
Showing 1 changed file with 3 additions and 7 deletions.
10 changes: 3 additions & 7 deletions drivers/cpufreq/amd-pstate.c
Original file line number Diff line number Diff line change
Expand Up @@ -319,13 +319,11 @@ static int shmem_set_epp(struct amd_cpudata *cpudata, u32 epp)
static int amd_pstate_set_energy_pref_index(struct amd_cpudata *cpudata,
int pref_index)
{
int epp = -EINVAL;
int ret;
int epp;

if (!pref_index)
epp = cpudata->epp_default;

if (epp == -EINVAL)
else
epp = epp_values[pref_index];

if (epp > 0 && cpudata->policy == CPUFREQ_POLICY_PERFORMANCE) {
Expand All @@ -341,9 +339,7 @@ static int amd_pstate_set_energy_pref_index(struct amd_cpudata *cpudata,
cpudata->boost_state);
}

ret = amd_pstate_set_epp(cpudata, epp);

return ret;
return amd_pstate_set_epp(cpudata, epp);
}

static inline int msr_cppc_enable(bool enable)
Expand Down

0 comments on commit f8fde68

Please sign in to comment.