Skip to content

Commit

Permalink
mmc: mxs: Initialize the spinlock prior to using it
Browse files Browse the repository at this point in the history
An interrupt may occur right after devm_request_irq() is called and
prior to the spinlock initialization, leading to a kernel oops,
as the interrupt handler uses the spinlock.

In order to prevent this problem, move the spinlock initialization
prior to requesting the interrupts.

Fixes: e4243f1 (mmc: mxs-mmc: add mmc host driver for i.MX23/28)
Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
Reviewed-by: Marek Vasut <marex@denx.de>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
  • Loading branch information
Fabio Estevam authored and Ulf Hansson committed Nov 7, 2016
1 parent fe1b570 commit f91346e
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/mmc/host/mxs-mmc.c
Original file line number Diff line number Diff line change
Expand Up @@ -661,13 +661,13 @@ static int mxs_mmc_probe(struct platform_device *pdev)

platform_set_drvdata(pdev, mmc);

spin_lock_init(&host->lock);

ret = devm_request_irq(&pdev->dev, irq_err, mxs_mmc_irq_handler, 0,
dev_name(&pdev->dev), host);
if (ret)
goto out_free_dma;

spin_lock_init(&host->lock);

ret = mmc_add_host(mmc);
if (ret)
goto out_free_dma;
Expand Down

0 comments on commit f91346e

Please sign in to comment.