Skip to content

Commit

Permalink
usb: mtu3: add a function to switch mailbox state to string
Browse files Browse the repository at this point in the history
By introducing mailbox_state_string(), allow to make debug
log more readable

Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Chunfeng Yun authored and Greg Kroah-Hartman committed Mar 26, 2019
1 parent 83374e0 commit f926da4
Showing 1 changed file with 18 additions and 2 deletions.
20 changes: 18 additions & 2 deletions drivers/usb/mtu3/mtu3_dr.c
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,22 @@ enum mtu3_vbus_id_state {
MTU3_VBUS_VALID,
};

static char *mailbox_state_string(enum mtu3_vbus_id_state state)
{
switch (state) {
case MTU3_ID_FLOAT:
return "ID_FLOAT";
case MTU3_ID_GROUND:
return "ID_GROUND";
case MTU3_VBUS_OFF:
return "VBUS_OFF";
case MTU3_VBUS_VALID:
return "VBUS_VALID";
default:
return "UNKNOWN";
}
}

static void toggle_opstate(struct ssusb_mtk *ssusb)
{
if (!ssusb->otg_switch.is_u3_drd) {
Expand Down Expand Up @@ -140,8 +156,8 @@ static void ssusb_set_mailbox(struct otg_switch_mtk *otg_sx,
container_of(otg_sx, struct ssusb_mtk, otg_switch);
struct mtu3 *mtu = ssusb->u3d;

dev_dbg(ssusb->dev, "mailbox state(%d)\n", status);
mtu3_dbg_trace(ssusb->dev, "mailbox %d", status);
dev_dbg(ssusb->dev, "mailbox %s\n", mailbox_state_string(status));
mtu3_dbg_trace(ssusb->dev, "mailbox %s", mailbox_state_string(status));

switch (status) {
case MTU3_ID_GROUND:
Expand Down

0 comments on commit f926da4

Please sign in to comment.