Skip to content

Commit

Permalink
Revert "serial: 8250_dma: don't bother DMA with small transfers"
Browse files Browse the repository at this point in the history
This reverts commit 9119fba.

This commit prevents from sending "big" file using Bluetooth.
When sending a lot of data quickly through the Bluetooth interface, and
after a variable amount of data sent, transfer fails with error:
    kernel: [  415.247453] Bluetooth: hci0 hardware error 0x00

Found on T100TA.

After reverting this commit, send works fine for any file size.

Signed-off-by: Frederic Danis <frederic.danis@linux.intel.com>
Fixes: 9119fba (serial: 8250_dma: don't bother DMA with small transfers)
Cc: stable@vger.kernel.org
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Frederic Danis authored and Greg Kroah-Hartman committed Oct 18, 2015
1 parent 25cb62b commit f967fc8
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions drivers/tty/serial/8250/8250_dma.c
Original file line number Diff line number Diff line change
Expand Up @@ -80,10 +80,6 @@ int serial8250_tx_dma(struct uart_8250_port *p)
return 0;

dma->tx_size = CIRC_CNT_TO_END(xmit->head, xmit->tail, UART_XMIT_SIZE);
if (dma->tx_size < p->port.fifosize) {
ret = -EINVAL;
goto err;
}

desc = dmaengine_prep_slave_single(dma->txchan,
dma->tx_addr + xmit->tail,
Expand Down

0 comments on commit f967fc8

Please sign in to comment.