Skip to content

Commit

Permalink
net: plip: fix break; causing plip to never transmit
Browse files Browse the repository at this point in the history
Since commit
  71ae2cb ("net: plip: Fix fall-through warnings for Clang")

plip was not able to send any packets, this patch replaces one
unintended break; with fallthrough; which was originally missed by
commit 9525d69 ("net: plip: mark expected switch fall-throughs").

I have verified with a real hardware PLIP connection that everything
works once again after applying this patch.

Fixes: 71ae2cb ("net: plip: Fix fall-through warnings for Clang")
Signed-off-by: Jakub Boehm <boehm.jakub@gmail.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Message-ID: <20241015-net-plip-tx-fix-v1-1-32d8be1c7e0b@gmail.com>
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
  • Loading branch information
Jakub Boehm authored and Andrew Lunn committed Oct 19, 2024
1 parent e4dd8bf commit f99cf99
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/net/plip/plip.c
Original file line number Diff line number Diff line change
Expand Up @@ -815,7 +815,7 @@ plip_send_packet(struct net_device *dev, struct net_local *nl,
return HS_TIMEOUT;
}
}
break;
fallthrough;

case PLIP_PK_LENGTH_LSB:
if (plip_send(nibble_timeout, dev,
Expand Down

0 comments on commit f99cf99

Please sign in to comment.