Skip to content

Commit

Permalink
init: properly placing noinline keyword
Browse files Browse the repository at this point in the history
checkpatch warns about 'static void noinline'.  It wants `static noinline
void'.

Both are permissible, but the kernel consistently uses `static inline' and
`static noinline', and consistency is good.  Hence let's keep the
checkpatch warning and fix up this code site.

[akpm@linux-foundation.org: rewrote changelog]
Signed-off-by: Md.Rakib H. Mullick <rakib.mullick@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Rakib Mullick authored and Linus Torvalds committed Jan 6, 2009
1 parent 91f4766 commit f99ebf0
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions init/main.c
Original file line number Diff line number Diff line change
Expand Up @@ -447,7 +447,7 @@ static void __init setup_command_line(char *command_line)
* gcc-3.4 accidentally inlines this function, so use noinline.
*/

static void noinline __init_refok rest_init(void)
static noinline void __init_refok rest_init(void)
__releases(kernel_lock)
{
int pid;
Expand Down Expand Up @@ -786,7 +786,7 @@ static void run_init_process(char *init_filename)
/* This is a non __init function. Force it to be noinline otherwise gcc
* makes it inline to init() and it becomes part of init.text section
*/
static int noinline init_post(void)
static noinline int init_post(void)
{
free_initmem();
unlock_kernel();
Expand Down

0 comments on commit f99ebf0

Please sign in to comment.