Skip to content

Commit

Permalink
ext4: use IS_ERR() to check for errors in ext4_error_file
Browse files Browse the repository at this point in the history
d_path() returns an ERR_PTR and it doesn't return NULL.  This is in
ext4_error_file() and no one actually calls ext4_error_file().

Signed-off-by: Dan Carpenter <error27@gmail.com>
  • Loading branch information
Dan Carpenter authored and Theodore Ts'o committed Jan 10, 2011
1 parent 1319518 commit f9a62d0
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion fs/ext4/super.c
Original file line number Diff line number Diff line change
Expand Up @@ -437,7 +437,7 @@ void ext4_error_file(struct file *file, const char *function,
save_error_info(inode->i_sb, function, line);
va_start(args, fmt);
path = d_path(&(file->f_path), pathname, sizeof(pathname));
if (!path)
if (IS_ERR(path))
path = "(unknown)";
printk(KERN_CRIT
"EXT4-fs error (device %s): %s:%d: inode #%lu "
Expand Down

0 comments on commit f9a62d0

Please sign in to comment.