Skip to content

Commit

Permalink
[PATCH] pi-futex: introduce debug_check_no_locks_freed()
Browse files Browse the repository at this point in the history
Add debug_check_no_locks_freed(), as a central inline to add
bad-lock-free-debugging functionality to.

Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
Ingo Molnar authored and Linus Torvalds committed Jun 28, 2006
1 parent 6abdce7 commit f9b8404
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 7 deletions.
4 changes: 2 additions & 2 deletions arch/i386/mm/pageattr.c
Original file line number Diff line number Diff line change
Expand Up @@ -229,8 +229,8 @@ void kernel_map_pages(struct page *page, int numpages, int enable)
if (PageHighMem(page))
return;
if (!enable)
mutex_debug_check_no_locks_freed(page_address(page),
numpages * PAGE_SIZE);
debug_check_no_locks_freed(page_address(page),
numpages * PAGE_SIZE);

/* the return value is ignored - the calls cannot fail,
* large pages are disabled at boot time.
Expand Down
10 changes: 8 additions & 2 deletions include/linux/mm.h
Original file line number Diff line number Diff line change
Expand Up @@ -1030,13 +1030,19 @@ static inline void vm_stat_account(struct mm_struct *mm,
}
#endif /* CONFIG_PROC_FS */

static inline void
debug_check_no_locks_freed(const void *from, unsigned long len)
{
mutex_debug_check_no_locks_freed(from, len);
}

#ifndef CONFIG_DEBUG_PAGEALLOC
static inline void
kernel_map_pages(struct page *page, int numpages, int enable)
{
if (!PageHighMem(page) && !enable)
mutex_debug_check_no_locks_freed(page_address(page),
numpages * PAGE_SIZE);
debug_check_no_locks_freed(page_address(page),
numpages * PAGE_SIZE);
}
#endif

Expand Down
4 changes: 2 additions & 2 deletions mm/page_alloc.c
Original file line number Diff line number Diff line change
Expand Up @@ -446,8 +446,8 @@ static void __free_pages_ok(struct page *page, unsigned int order)

arch_free_page(page, order);
if (!PageHighMem(page))
mutex_debug_check_no_locks_freed(page_address(page),
PAGE_SIZE<<order);
debug_check_no_locks_freed(page_address(page),
PAGE_SIZE<<order);

for (i = 0 ; i < (1 << order) ; ++i)
reserved += free_pages_check(page + i);
Expand Down
2 changes: 1 addition & 1 deletion mm/slab.c
Original file line number Diff line number Diff line change
Expand Up @@ -3397,7 +3397,7 @@ void kfree(const void *objp)
local_irq_save(flags);
kfree_debugcheck(objp);
c = virt_to_cache(objp);
mutex_debug_check_no_locks_freed(objp, obj_size(c));
debug_check_no_locks_freed(objp, obj_size(c));
__cache_free(c, (void *)objp);
local_irq_restore(flags);
}
Expand Down

0 comments on commit f9b8404

Please sign in to comment.