Skip to content

Commit

Permalink
bonding: Remove deprecated create_singlethread_workqueue
Browse files Browse the repository at this point in the history
alloc_ordered_workqueue() with WQ_MEM_RECLAIM set, replaces
deprecated create_singlethread_workqueue(). This is the identity
conversion.

The workqueue "wq" queues multiple work items viz
&bond->mcast_work, &nnw->work, &bond->mii_work, &bond->arp_work,
&bond->alb_work, &bond->mii_work, &bond->ad_work, &bond->slave_arr_work
which require strict execution ordering. Hence, an ordered dedicated
workqueue has been used.

Since, it is a network driver, WQ_MEM_RECLAIM has been set to
ensure forward progress under memory pressure.

Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
Acked-by: Tejun Heo <tj@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Bhaktipriya Shridhar authored and David S. Miller committed Sep 1, 2016
1 parent f4b63ea commit f9f225e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/net/bonding/bond_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -4627,7 +4627,7 @@ static int bond_init(struct net_device *bond_dev)

netdev_dbg(bond_dev, "Begin bond_init\n");

bond->wq = create_singlethread_workqueue(bond_dev->name);
bond->wq = alloc_ordered_workqueue(bond_dev->name, WQ_MEM_RECLAIM);
if (!bond->wq)
return -ENOMEM;

Expand Down

0 comments on commit f9f225e

Please sign in to comment.