Skip to content

Commit

Permalink
ACPI: processor: change acpi_processor_eval_pdc interface
Browse files Browse the repository at this point in the history
acpi_processor_eval_pdc() really only needs a handle and an
acpi_object_list * to do its work.

No need to pass in a struct acpi_processor *, so let's be more specific
about what we want.

Signed-off-by: Alex Chiang <achiang@hp.com>
Signed-off-by: Len Brown <len.brown@intel.com>
  • Loading branch information
Alex Chiang authored and Len Brown committed Dec 22, 2009
1 parent 3b407ae commit fa11856
Showing 1 changed file with 4 additions and 8 deletions.
12 changes: 4 additions & 8 deletions drivers/acpi/processor_pdc.c
Original file line number Diff line number Diff line change
Expand Up @@ -97,13 +97,11 @@ static struct acpi_object_list *acpi_processor_alloc_pdc(void)
* _PDC is required for a BIOS-OS handshake for most of the newer
* ACPI processor features.
*/
static int acpi_processor_eval_pdc(struct acpi_processor *pr)
static int
acpi_processor_eval_pdc(acpi_handle handle, struct acpi_object_list *pdc_in)
{
struct acpi_object_list *pdc_in = pr->pdc;
acpi_status status = AE_OK;

if (!pdc_in)
return status;
if (idle_nomwait) {
/*
* If mwait is disabled for CPU C-states, the C2C3_FFH access
Expand All @@ -118,7 +116,7 @@ static int acpi_processor_eval_pdc(struct acpi_processor *pr)
buffer[2] &= ~(ACPI_PDC_C_C2C3_FFH | ACPI_PDC_C_C1_FFH);

}
status = acpi_evaluate_object(pr->handle, "_PDC", pdc_in, NULL);
status = acpi_evaluate_object(handle, "_PDC", pdc_in, NULL);

if (ACPI_FAILURE(status))
ACPI_DEBUG_PRINT((ACPI_DB_INFO,
Expand Down Expand Up @@ -148,9 +146,7 @@ void acpi_processor_set_pdc(struct acpi_processor *pr)
if (!obj_list)
return;

pr->pdc = obj_list;

acpi_processor_eval_pdc(pr);
acpi_processor_eval_pdc(pr->handle, obj_list);
acpi_processor_cleanup_pdc(pr);
}
EXPORT_SYMBOL_GPL(acpi_processor_set_pdc);
Expand Down

0 comments on commit fa11856

Please sign in to comment.