Skip to content

Commit

Permalink
iio: gyro: fxas21002c: Fix missing data update in trigger handler
Browse files Browse the repository at this point in the history
The fxas21002c_trigger_handler() may fail to acquire sample data because
the runtime PM enters the autosuspend state and sensor can not return
sample data in standby mode..

Resume the sensor before reading the sample data into the buffer within the
trigger handler. After the data is read, place the sensor back into the
autosuspend state.

Fixes: a0701b6 ("iio: gyro: add core driver for fxas21002c")
Signed-off-by: Carlos Song <carlos.song@nxp.com>
Signed-off-by: Frank Li <Frank.Li@nxp.com>
Link: https://patch.msgid.link/20241116152945.4006374-1-Frank.Li@nxp.com
Cc: <Stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
  • Loading branch information
Carlos Song authored and Jonathan Cameron committed Dec 7, 2024
1 parent aaa90d0 commit fa13ac6
Showing 1 changed file with 8 additions and 1 deletion.
9 changes: 8 additions & 1 deletion drivers/iio/gyro/fxas21002c_core.c
Original file line number Diff line number Diff line change
Expand Up @@ -730,14 +730,21 @@ static irqreturn_t fxas21002c_trigger_handler(int irq, void *p)
int ret;

mutex_lock(&data->lock);
ret = fxas21002c_pm_get(data);
if (ret < 0)
goto out_unlock;

ret = regmap_bulk_read(data->regmap, FXAS21002C_REG_OUT_X_MSB,
data->buffer, CHANNEL_SCAN_MAX * sizeof(s16));
if (ret < 0)
goto out_unlock;
goto out_pm_put;

iio_push_to_buffers_with_timestamp(indio_dev, data->buffer,
data->timestamp);

out_pm_put:
fxas21002c_pm_put(data);

out_unlock:
mutex_unlock(&data->lock);

Expand Down

0 comments on commit fa13ac6

Please sign in to comment.