Skip to content

Commit

Permalink
perf: Shrink hw_perf_event
Browse files Browse the repository at this point in the history
Use hw_perf_event::period_left instead of hw_perf_event::remaining
and win back 8 bytes.

Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: paulus <paulus@samba.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
LKML-Reference: <new-submission>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
  • Loading branch information
Peter Zijlstra authored and Ingo Molnar committed Sep 9, 2010
1 parent ad5133b commit fa407f3
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 8 deletions.
1 change: 0 additions & 1 deletion include/linux/perf_event.h
Original file line number Diff line number Diff line change
Expand Up @@ -529,7 +529,6 @@ struct hw_perf_event {
int last_cpu;
};
struct { /* software */
s64 remaining;
struct hrtimer hrtimer;
};
#ifdef CONFIG_HAVE_HW_BREAKPOINT
Expand Down
13 changes: 6 additions & 7 deletions kernel/perf_event.c
Original file line number Diff line number Diff line change
Expand Up @@ -4800,14 +4800,13 @@ static void perf_swevent_start_hrtimer(struct perf_event *event)
hrtimer_init(&hwc->hrtimer, CLOCK_MONOTONIC, HRTIMER_MODE_REL);
hwc->hrtimer.function = perf_swevent_hrtimer;
if (hwc->sample_period) {
u64 period;
s64 period = local64_read(&hwc->period_left);

if (hwc->remaining) {
if (hwc->remaining < 0)
if (period) {
if (period < 0)
period = 10000;
else
period = hwc->remaining;
hwc->remaining = 0;

local64_set(&hwc->period_left, 0);
} else {
period = max_t(u64, 10000, hwc->sample_period);
}
Expand All @@ -4823,7 +4822,7 @@ static void perf_swevent_cancel_hrtimer(struct perf_event *event)

if (hwc->sample_period) {
ktime_t remaining = hrtimer_get_remaining(&hwc->hrtimer);
hwc->remaining = ktime_to_ns(remaining);
local64_set(&hwc->period_left, ktime_to_ns(remaining));

hrtimer_cancel(&hwc->hrtimer);
}
Expand Down

0 comments on commit fa407f3

Please sign in to comment.