Skip to content

Commit

Permalink
Bluetooth: Fix debugfs entry leak in hci_register_dev()
Browse files Browse the repository at this point in the history
[ Upstream commit 5a4bb6a ]

Fault injection test report debugfs entry leak as follows:

debugfs: Directory 'hci0' with parent 'bluetooth' already present!

When register_pm_notifier() failed in hci_register_dev(), the debugfs
create by debugfs_create_dir() do not removed in the error handing path.

Add the remove debugfs code to fix it.

Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
Wei Yongjun authored and Greg Kroah-Hartman committed Jan 27, 2022
1 parent 2b09cb8 commit fa4ca50
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions net/bluetooth/hci_core.c
Original file line number Diff line number Diff line change
Expand Up @@ -3387,6 +3387,7 @@ int hci_register_dev(struct hci_dev *hdev)
return id;

err_wqueue:
debugfs_remove_recursive(hdev->debugfs);
destroy_workqueue(hdev->workqueue);
destroy_workqueue(hdev->req_workqueue);
err:
Expand Down

0 comments on commit fa4ca50

Please sign in to comment.