Skip to content

Commit

Permalink
net: hns3: Add handle for default case
Browse files Browse the repository at this point in the history
There are a few "switch-case" codes missed handle for default case. For
some abnormal case, it should return error code instead of return 0.

Signed-off-by: Jian Shen <shenjian15@huawei.com>
Signed-off-by: Peng Li <lipeng321@huawei.com>
Signed-off-by: Salil Mehta <salil.mehta@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Jian Shen authored and David S. Miller committed Sep 22, 2018
1 parent 6cee6fc commit fa7a4bd
Show file tree
Hide file tree
Showing 5 changed files with 20 additions and 6 deletions.
2 changes: 2 additions & 0 deletions drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
Original file line number Diff line number Diff line change
Expand Up @@ -2176,6 +2176,8 @@ static void hns3_rx_checksum(struct hns3_enet_ring *ring, struct sk_buff *skb,
l4_type == HNS3_L4_TYPE_SCTP))
skb->ip_summed = CHECKSUM_UNNECESSARY;
break;
default:
break;
}
}

Expand Down
7 changes: 5 additions & 2 deletions drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c
Original file line number Diff line number Diff line change
Expand Up @@ -351,9 +351,10 @@ static int hns3_get_sset_count(struct net_device *netdev, int stringset)

case ETH_SS_TEST:
return ops->get_sset_count(h, stringset);
}

return 0;
default:
return -EOPNOTSUPP;
}
}

static void *hns3_update_strings(u8 *data, const struct hns3_stats *stats,
Expand Down Expand Up @@ -417,6 +418,8 @@ static void hns3_get_strings(struct net_device *netdev, u32 stringset, u8 *data)
case ETH_SS_TEST:
ops->get_strings(h, stringset, data);
break;
default:
break;
}
}

Expand Down
6 changes: 6 additions & 0 deletions drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -2224,6 +2224,8 @@ static void hclge_clear_event_cause(struct hclge_dev *hdev, u32 event_type,
case HCLGE_VECTOR0_EVENT_MBX:
hclge_write_dev(&hdev->hw, HCLGE_VECTOR0_CMDQ_SRC_REG, regclr);
break;
default:
break;
}
}

Expand Down Expand Up @@ -5218,6 +5220,10 @@ static int hclge_init_client_instance(struct hnae3_client *client,

hnae3_set_client_init_flag(client, ae_dev, 1);
}

break;
default:
return -EINVAL;
}
}

Expand Down
8 changes: 4 additions & 4 deletions drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_cmd.c
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ static int hclgevf_init_cmd_queue(struct hclgevf_dev *hdev,

hclgevf_write_dev(hw, HCLGEVF_NIC_CSQ_HEAD_REG, 0);
hclgevf_write_dev(hw, HCLGEVF_NIC_CSQ_TAIL_REG, 0);
break;
return 0;
case HCLGEVF_TYPE_CRQ:
reg_val = (u32)ring->desc_dma_addr;
hclgevf_write_dev(hw, HCLGEVF_NIC_CRQ_BASEADDR_L_REG, reg_val);
Expand All @@ -147,10 +147,10 @@ static int hclgevf_init_cmd_queue(struct hclgevf_dev *hdev,

hclgevf_write_dev(hw, HCLGEVF_NIC_CRQ_HEAD_REG, 0);
hclgevf_write_dev(hw, HCLGEVF_NIC_CRQ_TAIL_REG, 0);
break;
return 0;
default:
return -EINVAL;
}

return 0;
}

void hclgevf_cmd_setup_basic_desc(struct hclgevf_desc *desc,
Expand Down
3 changes: 3 additions & 0 deletions drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -1667,6 +1667,9 @@ static int hclgevf_init_client_instance(struct hnae3_client *client,
}

hnae3_set_client_init_flag(client, ae_dev, 1);
break;
default:
return -EINVAL;
}

return 0;
Expand Down

0 comments on commit fa7a4bd

Please sign in to comment.