Skip to content

Commit

Permalink
r8169: fix incorrect args to oob notify.
Browse files Browse the repository at this point in the history
It results in the wrong point address and influences RTL8168DP.

Signed-off-by: Hayes Wang <hayeswang@realtek.com>
Acked-by: Francois Romieu <romieu@fr.zoreil.com>
  • Loading branch information
Hayes Wang authored and Francois Romieu committed Feb 23, 2011
1 parent d3bd1b4 commit fac5b3c
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions drivers/net/r8169.c
Original file line number Diff line number Diff line change
Expand Up @@ -617,8 +617,9 @@ static void ocp_write(struct rtl8169_private *tp, u8 mask, u16 reg, u32 data)
}
}

static void rtl8168_oob_notify(void __iomem *ioaddr, u8 cmd)
static void rtl8168_oob_notify(struct rtl8169_private *tp, u8 cmd)
{
void __iomem *ioaddr = tp->mmio_addr;
int i;

RTL_W8(ERIDR, cmd);
Expand All @@ -630,7 +631,7 @@ static void rtl8168_oob_notify(void __iomem *ioaddr, u8 cmd)
break;
}

ocp_write(ioaddr, 0x1, 0x30, 0x00000001);
ocp_write(tp, 0x1, 0x30, 0x00000001);
}

#define OOB_CMD_RESET 0x00
Expand Down

0 comments on commit fac5b3c

Please sign in to comment.