Skip to content

Commit

Permalink
ARM: dts: imx53-qsb: select open-drain mode for i2c1 pads
Browse files Browse the repository at this point in the history
Both imx53-qsb and imx53-qsrb don't have external pull-up resistors
on the I2C1 SCL and SDA lines populated. Select open-drain mode and
enable the internal pull-up for both.

Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
  • Loading branch information
Lucas Stach authored and Shawn Guo committed Jul 15, 2015
1 parent 97dae85 commit fb00ff4
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 15 deletions.
5 changes: 3 additions & 2 deletions arch/arm/boot/dts/imx53-qsb-common.dtsi
Original file line number Diff line number Diff line change
Expand Up @@ -228,10 +228,11 @@
>;
};

/* open drain */
pinctrl_i2c1: i2c1grp {
fsl,pins = <
MX53_PAD_CSI0_DAT8__I2C1_SDA 0xc0000000
MX53_PAD_CSI0_DAT9__I2C1_SCL 0xc0000000
MX53_PAD_CSI0_DAT8__I2C1_SDA 0x400001ec
MX53_PAD_CSI0_DAT9__I2C1_SCL 0x400001ec
>;
};

Expand Down
14 changes: 1 addition & 13 deletions arch/arm/boot/dts/imx53-qsrb.dts
Original file line number Diff line number Diff line change
Expand Up @@ -20,15 +20,7 @@
};

&iomuxc {
i2c1 {
/* open drain */
pinctrl_i2c1_qsrb: i2c1grp-1 {
fsl,pins = <
MX53_PAD_CSI0_DAT8__I2C1_SDA 0x400001ec
MX53_PAD_CSI0_DAT9__I2C1_SCL 0x400001ec
>;
};

imx53-qsrb {
pinctrl_pmic: pmicgrp {
fsl,pins = <
MX53_PAD_CSI0_DAT5__GPIO5_23 0x1e4 /* IRQ */
Expand All @@ -38,10 +30,6 @@
};

&i2c1 {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_i2c1_qsrb>;
status = "okay";

pmic: mc34708@8 {
compatible = "fsl,mc34708";
pinctrl-names = "default";
Expand Down

0 comments on commit fb00ff4

Please sign in to comment.