Skip to content

Commit

Permalink
irqchip: Remove redundant error printing
Browse files Browse the repository at this point in the history
When devm_ioremap_resource() fails, a clear enough error message will be
printed by its subfunction __devm_ioremap_resource(). The error
information contains the device name, failure cause, and possibly resource
information.

Therefore, remove the error printing here to simplify code and reduce the
binary size.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20210511125428.6108-2-thunder.leizhen@huawei.com
  • Loading branch information
Zhen Lei authored and Marc Zyngier committed May 16, 2021
1 parent 5b44955 commit fbb80d5
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 9 deletions.
4 changes: 1 addition & 3 deletions drivers/irqchip/irq-mvebu-icu.c
Original file line number Diff line number Diff line change
Expand Up @@ -359,10 +359,8 @@ static int mvebu_icu_probe(struct platform_device *pdev)

res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
icu->base = devm_ioremap_resource(&pdev->dev, res);
if (IS_ERR(icu->base)) {
dev_err(&pdev->dev, "Failed to map icu base address.\n");
if (IS_ERR(icu->base))
return PTR_ERR(icu->base);
}

/*
* Legacy bindings: ICU is one node with one MSI parent: force manually
Expand Down
4 changes: 1 addition & 3 deletions drivers/irqchip/irq-mvebu-sei.c
Original file line number Diff line number Diff line change
Expand Up @@ -384,10 +384,8 @@ static int mvebu_sei_probe(struct platform_device *pdev)

sei->res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
sei->base = devm_ioremap_resource(sei->dev, sei->res);
if (IS_ERR(sei->base)) {
dev_err(sei->dev, "Failed to remap SEI resource\n");
if (IS_ERR(sei->base))
return PTR_ERR(sei->base);
}

/* Retrieve the SEI capabilities with the interrupt ranges */
sei->caps = of_device_get_match_data(&pdev->dev);
Expand Down
4 changes: 1 addition & 3 deletions drivers/irqchip/irq-stm32-exti.c
Original file line number Diff line number Diff line change
Expand Up @@ -892,10 +892,8 @@ static int stm32_exti_probe(struct platform_device *pdev)

res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
host_data->base = devm_ioremap_resource(dev, res);
if (IS_ERR(host_data->base)) {
dev_err(dev, "Unable to map registers\n");
if (IS_ERR(host_data->base))
return PTR_ERR(host_data->base);
}

for (i = 0; i < drv_data->bank_nr; i++)
stm32_exti_chip_init(host_data, i, np);
Expand Down

0 comments on commit fbb80d5

Please sign in to comment.